java problem, please help

[PRIMO]

I need to create a method that can simplify a fraction, that is, represent it as a fraction where the numerator and the denominator have no common divisors. it should read in the numerator and the denominator and then print out the fraction in its simplified form.

since dividing the numerator and denominator by their gcd will simplify the fraction.
here is a sample run (user input)
enter a numerator:
6
enter a denominator:
8

your fraction is 6/8
the simplified form is 3/4

I wrote this code and it compiles and makes sense to me at least. However, it doesn't work properly for more difficult integers like 20, 30. Can anyone spot the problem. nothing is wrong with the compiling, just doesn't work logically. I can't use the Euclidean Algorithm, so I basically had to write the simplest program to find gcd.


public static int gcd(int a, int b)

{

int gcd;

if (a > b && a % b == 0)

{

gcd = b;

return gcd;

}

else if (b > a && b % a == 0)

{

gcd = a;

return gcd;

}

else if (a > b && a % b != 0)

{

int count = b;

do

{

count = count - 1;

}

while (b % count != 0 && a % count != 0);

gcd = count;

return gcd;

}

else if (b > a && b % a != 0)

{

int count = a;

do

{

count = count - 1;

}

while (b % count != 0 && a % count != 0);

gcd = count;

return gcd;

}

else

{

gcd = a;

return gcd;

}

}

[omonija]

i think your problem is your structure. too many if-elses and whiles in the same block of code is usually a sign of trouble.

why don't you consider doing it like this: create an array of factors for each number, then go through and compare both arrays. select the largest common factor, and divide both by the number, then present your answer? that should take like only 3 while/for loops. let me know if you want further explanations.

also, it may be better to use matlab for this, unless you absolutely must use java.

[COMMONCENTS]

yeah thats way too messy....i dont know much about java, but basic data structures is definitely missing in that code.

[COMMONCENTS]

ok if u have n/d,
write a while i > 0,
}
if n%a = 0 && d%a = 0
then display n/a '/' d/a
else
i-1
}
basic data structure.
thats more for c/c++ sha.

[bettybogus]

clean up your code, dude.. you only need one return statement.. after all the if else statements.. I'd help.. but, I'm a little busy right now..

[PRIMO]

Originally Posted by COMMONCENTS

ok if u have n/d,
write a while i > 0,
}
if n%a = 0 && d%a = 0
then display n/a '/' d/a
else
i-1
}
basic data structure.
thats more for c/c++ sha.

did you compile it with that and it runs?

[aba made]

Originally Posted by PRIMO

did you compile it with that and it runs?

lol. is this a joke?

[COMMONCENTS]

Originally Posted by PRIMO

did you compile it with that and it runs?

thats not in any language...just giving u an idea of how u should go about it in any language u decide to use it with.

if i was to write i'd use c++, and i's only need one while loop and one if statement.

[PRIMO]

Originally Posted by aba made

lol. is this a joke?

thats not a joke aba boy

[omonija]

Originally Posted by PRIMO

did you compile it with that and it runs?

see dis kopykata

even if that works, that would only be the first part. maybe you should say what your logic is. your code isn't clear at all.

[COMMONCENTS]

Originally Posted by aba made

lol. is this a joke?

lol....

[PRIMO]

i seriously need help, make una help and stop making fun of my condition. I don loose sleep for 2 night becos of this nonsense

[PRIMO]

why una dey act like say no be one nigeria wey we be

[ebunoluwa]

Did you clean it up at all based on the suggested comments? What's your code looking like now and is it still not working?

[PRIMO]

^it still no dey work. i don try many ways, but it still dey give me errorrs. please work with me, compile and run it and help me figure where the problem is